Fully remove ThinClient from bench-tps#132
Merged
gregcusack merged 1 commit intoanza-xyz:masterfrom Mar 12, 2024
Merged
Conversation
gregcusack
changed the title
ThinClient from bench-tpsThinClient from bench-tps
gregcusack
force-pushed
the
remove-thin-client-from-bench-tps
branch
from
363af0a to
01f1dfe
Compare
gregcusack
force-pushed
the
remove-thin-client-from-bench-tps
branch
from
01f1dfe to
a81abff
Compare
CriesofCarrots
approved these changes
Mar 12, 2024
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
\o/ Thanks for you patience through this!
Author
haha i should be thanking you! thank you! |
This was referenced Mar 13, 2024
codebender828
pushed a commit
to codebender828/agave
that referenced
this pull request
Oct 3, 2024
remove ThinClient from bench-tps
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
…z#132) Previous version was just broken. It is supposed to forward execution to an implementation that is in the source tree, but it was looking for the implementation in the wrong location. `git rev-parse --git-dir` is a more robust way. And we need `git` to work for this script to make any sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6th PR on the way to remove
ThinClientcompletely.See
bench-tpsclient totpu-clientsolana-labs/solana#35335ThinClientand removeThinClientfrombench-tpssolana-labs/solana#35365get_clientandget_multi_client#177get_clientandget_multi_client#184ThinClientfromdos/#117This PR requires PR: #117 to be merged before this one!
Problem
ThinClientis deprecated, so we need to it frombench-tpsSummary of Changes
Fully remove
ThinClientfrombench-tps